feat: add Storybook #66
Conversation
riccardo-forina
commented
Sep 23, 2019
•
riccardo-forina
commented
There was a problem hiding this comment.
Very useful for a lot of projects, thank you!!
It looks good, I left a few questions. Other than those the only things I wanted to ask about is adding storybook-static to the gitignore and if you know what gives on either of these warnings or error?
I get the error when resizing the browser window down to a small viewport. It looks like those breakpoints might be customizable, is there a way to align the storybook breakpoints with those defined in patternfly?
Awesome work!
package.json
Outdated
| "clean": "rimraf dist" | ||
| "clean": "rimraf dist", | ||
| "storybook": "start-storybook -p 6006", | ||
| "build-storybook": "build-storybook" |
There was a problem hiding this comment.
Can we change it to build:storybook, and maybe update the existing build script to be build:app, that way they all follow a same pattern?
riccardo-forina
force-pushed
the
storybook
branch
from
89b5028
to
1179e49
Compare
|
Thanks for the feedback! The warning bit was tricky, Storybook's own Webpack's config was providing some default CSS loader that wasn't compatible with the one needed for PatternFly. |
There was a problem hiding this comment.
Nice work @riccardo-forina - looks great 💙 I checked and that error about active prop is a known issue - storybookjs/storybook#5910 - which has been reopened, so hopefully, we'll just inherit the fix at some point once it's posted.
Thanks again, this will surely save people some time on the initial setup 👍
