Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - MenuToggleCheckbox - indeterminate console error #10034

Closed
kmcfaul opened this issue Jan 23, 2024 · 0 comments · Fixed by #10066
Closed

Bug - MenuToggleCheckbox - indeterminate console error #10034

kmcfaul opened this issue Jan 23, 2024 · 0 comments · Fixed by #10066
Assignees
@kmcfaul
Labels
bug
Milestone
2024.Q1

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Jan 23, 2024 •
edited

Setting the checkbox to be indeterminate via isChecked={null} is triggering an error that indicates a "controlled input is becoming uncontrolled" in the console.

To resolve - checked should be set by calculateChecked instead.

Also, the error was not showing on the docs site but is showing on codesandbox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcfaul kmcfaul

Labels
bug
Projects
PatternFly Issues
Archived in project
Milestone
2024.Q1
Development

Successfully merging a pull request may close this issue.

fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior kmcfaul/patternfly-react
3 participants
@wise-king-sullyman @tlabaj @kmcfaul