Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6 Button - prevent aria-disabled from being set by isDisabled prop #10210

Closed
adamviktora opened this issue Mar 27, 2024 · 2 comments · Fixed by #10255
Closed

v6 Button - prevent aria-disabled from being set by isDisabled prop #10210

adamviktora opened this issue Mar 27, 2024 · 2 comments · Fixed by #10255
Assignees
@adamviktora
Labels
accessibility sm
Milestone
Penta beta release

Comments

@adamviktora
Copy link
Contributor

Followup to: #10199 (review)
@adamviktora adamviktora changed the title Button - prevent aria-disabled being set by isDisabled prop Button - prevent aria-disabled from being set by isDisabled prop Mar 27, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Apr 4, 2024

We should also clean up pf-m-disabled as mentioned here #10199 (comment)

@tlabaj tlabaj changed the title Button - prevent aria-disabled from being set by isDisabled prop v6 Button - prevent aria-disabled from being set by isDisabled prop Apr 4, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Apr 4, 2024
@tlabaj tlabaj added the sm label Apr 4, 2024
@adamviktora adamviktora self-assigned this Apr 8, 2024
@adamviktora adamviktora mentioned this issue Apr 8, 2024
Merged
@adamviktora adamviktora linked a pull request Apr 8, 2024 that will close this issue
feat(Button): change behaviour of isDisabled prop #10255
Merged
@thatblindgeye
Copy link
Contributor

Closed by #10255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
accessibility sm
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

feat(Button): change behaviour of isDisabled prop adamviktora/patternfly-react
3 participants
@tlabaj @thatblindgeye @adamviktora