Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal examples needed for testing #1044

Closed
jgiardino opened this issue Dec 12, 2018 · 1 comment
Closed

Modal examples needed for testing #1044

jgiardino opened this issue Dec 12, 2018 · 1 comment
Assignees
Labels
accessibility PF4 React issues for the PF4 core effort
Milestone

Comments

@jgiardino
Copy link
Collaborator

As noted in patternfly/patternfly#925, some working examples of the modal are needed to better understand how the aria and role attributes might affect the behavior of a modal in screen readers.

Can we have a WIP PR created with the following examples?

  • example with aria-label (refer to core example "ModalBox No Header Example" and use of aria-label on .pf-c-modal-box)
  • example with aria-labelledby
  • example with aria-describedby
  • example with contents included in the modal other than the aria-describedby contents, header, and buttons (refer to core example "ModalBox No Header Example" and use of <span id="modal-no-header-description">)
  • one example where contents are text and one where contents are a form would be ideal

For each example above, there should be two examples:

  • one with role="dialog" aria-modal="true"
  • and one without these attributes
@rachael-phillips
Copy link
Contributor

Closing this issue, completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility PF4 React issues for the PF4 core effort
Projects
None yet
Development

No branches or pull requests

4 participants