Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application launcher enhancements #3227

Closed
rachael-phillips opened this issue Oct 28, 2019 · 1 comment · Fixed by #3371
Closed

Application launcher enhancements #3227

rachael-phillips opened this issue Oct 28, 2019 · 1 comment · Fixed by #3371
Assignees
Labels
enhancement 🚀 PF4 React issues for the PF4 core effort
Milestone

Comments

@rachael-phillips
Copy link
Contributor

rachael-phillips commented Oct 28, 2019

This is a React implementation follow-up to Core issue patternfly/patternfly#2365. This React issue is on hold until patternfly/patternfly#2365 has been closed.

@rachael-phillips rachael-phillips added enhancement 🚀 on hold PF4 React issues for the PF4 core effort labels Oct 28, 2019
@rachael-phillips rachael-phillips added this to the Prioritized Backlog milestone Oct 28, 2019
@kmcfaul kmcfaul self-assigned this Oct 29, 2019
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2019.10 Oct 30, 2019
@tlabaj tlabaj removed the on hold label Nov 19, 2019
@mcoker
Copy link
Contributor

mcoker commented Nov 21, 2019

patternfly/patternfly#2428 is merged

  • Creates a new element .pf-c-app-launcher__menu-search to hold the text input form control for searching the menu.
  • Creates a new element .pf-c-app-launcher__menu-wrapper to be used as the list item that will wrap the item link and button inside when used with a favorites menu. Technically this could be used outside of the context of favorites in the future if we wanted to have more actions beside a link in an app launcher that do other things. This is just a way to establish a list item that will then take a link and action(s).
    • This gets the class .pf-m-favorite when an item in the list has been favorited.
  • Creates a variation for .pf-c-app-launcher__menu-item called .pf-m-link that serves as the link inside .pf-c-app-launcher__menu-wrapper
  • Creates a variation for .pf-c-app-launcher__menu-item called .pf-m-action that serves as an action inside .pf-c-app-launcher__menu-wrapper. Technically this could be anything, not just a favorite button. And I suppose you could have more than 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 PF4 React issues for the PF4 core effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants