Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some react tokens have wrong values #4583

Closed
jschuler opened this issue Jul 20, 2020 · 4 comments · Fixed by #6418
Closed

Some react tokens have wrong values #4583

jschuler opened this issue Jul 20, 2020 · 4 comments · Fixed by #6418
Assignees
Labels
Milestone

Comments

@jschuler
Copy link
Collaborator

For example global_BackgroundColor_100,

export const global_BackgroundColor_100 = {
  "name": "--pf-global--BackgroundColor--100",
  "value": "#151515",
  "var": "var(--pf-global--BackgroundColor--100)"
};
export default global_BackgroundColor_100;

The value should be #fff

@stale
Copy link

stale bot commented Sep 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Sep 20, 2020
@guillaumevincent
Copy link
Contributor

Don't close this one bot ! 😄

@stale stale bot removed the wontfix label Sep 21, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 21, 2020
@jschuler jschuler added pinned and removed wontfix labels Nov 30, 2020
@vkrizan
Copy link

vkrizan commented Dec 21, 2020

When writing tokens, the values in a tree gets flatten and overwritten.

tokens['patternfly_variables'][':root'] == { 
  name: '--pf-global--BackgroundColor--100', value: '#fff' 
}

tokens['c_about_modal_box']['.pf-c-about-modal-box'] == {
  name: '--pf-global--BackgroundColor--100',
  value: '#151515',
  ^^^^^^^^^^^^^^^^^
  values: [
    '--pf-global--BackgroundColor--dark-100',
    '$pf-global--BackgroundColor--dark-100',
    '$pf-color-black-900',
    ^^^^^^^^^^^^^^^^^^^^^^
    '#151515'
    ^^^^^^^^^
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants