Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search input] - [Suggested api changes while beta] #8428

Closed
tlabaj opened this issue Dec 7, 2022 · 0 comments · Fixed by #8516
Closed

[Search input] - [Suggested api changes while beta] #8428

tlabaj opened this issue Dec 7, 2022 · 0 comments · Fixed by #8516
Assignees
@wise-king-sullyman
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience. PF4 React issues for the PF4 core effort
Milestone
2023.01

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Dec 7, 2022 •
edited

Is this a new component or an extension of an existing one?
Search Input

Describe the feature

  1. SearchInput
    Change the order of the params in the following SearchInput props so event is first:
  • onChange
  • onSearch
  1. ExpandableInput interface
  • Rename to SearchInputExpandable so name is prepended with component name.
  • Change the order of the params in onToggleExpand so event is first
  1. Prepend component name to SearchAttribute so it would be SearchInputSearchAttribute

These changes should be made while beta.
@tlabaj tlabaj added Feature end user feature that requires design to define this, i.e. changes or augments the user experience. needs triage labels Dec 7, 2022
@mcarrano mcarrano added this to the 2023.01 milestone Dec 13, 2022
@tlabaj tlabaj added the PF4 React issues for the PF4 core effort label Dec 16, 2022
This was referenced Jan 9, 2023
Merged
Merged
@wise-king-sullyman wise-king-sullyman linked a pull request Jan 16, 2023 that will close this issue
chore(SearchInput): reordered props in onChange and onSearch #8516
Merged
This was referenced Jan 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience. PF4 React issues for the PF4 core effort
Projects
PatternFly Issues
Archived in project
Milestone
2023.01
Development

Successfully merging a pull request may close this issue.

chore(SearchInput): reordered props in onChange and onSearch wise-king-sullyman/patternfly-react
3 participants
@mcarrano @wise-king-sullyman @tlabaj