Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we're using list roles properly #8453

Closed
mcoker opened this issue Dec 15, 2022 · 0 comments · Fixed by #8702
Closed

Ensure we're using list roles properly #8453

mcoker opened this issue Dec 15, 2022 · 0 comments · Fixed by #8702
Assignees
@thatblindgeye
Labels
breaking change 💥 this change requires a major release and has API changes. PF5
Milestone
2023.04

Comments

@mcoker
Copy link
Contributor

mcoker commented Dec 15, 2022

Placeholder for core work in patternfly/patternfly#5262

For any lists that might lose their role based on styling, we need to make sure the role is updated so it maintains the proper role in the a11y tree.

cc @thatblindgeye
@mcoker mcoker added breaking change 💥 this change requires a major release and has API changes. PF5 labels Dec 15, 2022
@mcoker mcoker added this to the Breaking Changes milestone Dec 15, 2022
@tlabaj tlabaj modified the milestones: Breaking Changes, 2023.03 Dec 16, 2022
@thatblindgeye thatblindgeye self-assigned this Feb 15, 2023
This was referenced Feb 15, 2023
Closed
Merged
@thatblindgeye thatblindgeye modified the milestones: 2023.03, 2023.04 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
breaking change 💥 this change requires a major release and has API changes. PF5
Projects
PatternFly Issues
Archived in project
Milestone
2023.04
Development

Successfully merging a pull request may close this issue.

fix(lists): added role to list elements within components thatblindgeye/patternfly-react
3 participants
@mcoker @tlabaj @thatblindgeye