Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - SearchInput demos onChange prop order #8941

Closed
Tracked by #44
MariaAga opened this issue Apr 12, 2023 · 0 comments · Fixed by #8999
Closed
Tracked by #44

Bug - SearchInput demos onChange prop order #8941

MariaAga opened this issue Apr 12, 2023 · 0 comments · Fixed by #8999
Assignees
@kmcfaul
Labels
bug PF5
Milestone
2023.06

Comments

@MariaAga
Copy link
Contributor

in packages/react-core/src/demos/SearchInput/SearchInput.md there are 2 leftovers onChange that didnt get a prop order reorder after #8516:
in the Search with autocomplete and Composable advanced search sections
const onChange = (value) => { , const onChange = (newValue) => {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcfaul kmcfaul

Labels
bug PF5
Projects
PatternFly Issues
Archived in project
Milestone
2023.06
Development

Successfully merging a pull request may close this issue.

fix(SearchInput demos): add event kmcfaul/patternfly-react
3 participants
@nicolethoen @MariaAga @kmcfaul