Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gutters to the layouts #132

Closed
cliffpyles opened this issue Apr 11, 2018 · 3 comments
Closed

Add gutters to the layouts #132

cliffpyles opened this issue Apr 11, 2018 · 3 comments
Assignees
@andresgalante @kybaker @srambach
Milestone
1.0.0-alpha.1

Comments

@cliffpyles
Copy link
Contributor

To account for spacing between the layouts' child elements we need to add gutter values to the layouts. Design will provide the appropriate gutter sizes.
@LHinson LHinson added this to the 1.0.0-alpha.1 milestone Apr 11, 2018
@LHinson
Copy link
Member

LHinson commented Apr 11, 2018

per @andresgalante and @kybaker

use the --lg spacer for the gutters when the has-gutter class is present

@LHinson LHinson moved this from Document to Build in PatternFly-Next Feature Board Apr 12, 2018
@LHinson
Copy link
Member

LHinson commented Apr 20, 2018

This is related to #100 and should be done together

@LHinson LHinson added the css label Apr 20, 2018
srambach referenced this issue in srambach/patternfly-next Apr 30, 2018
@srambach
Adds gutters and tests layouts (#100 and #132)
98c7eb2
@srambach srambach mentioned this issue Apr 30, 2018
Merged
srambach referenced this issue in srambach/patternfly-next May 3, 2018
@srambach
Adds gutters and tests layouts (#100 and #132)
7e20003
andresgalante pushed a commit that referenced this issue May 3, 2018
@srambach @andresgalante
Add gutters and IE support to general layouts (#190)
9bd24c5 
* Add IE11 fixes to the layouts

* Adds gutters and tests layouts (#100 and #132)

* Adjusts documentation markdown

* Fixes gutter variable and other corrections

* Fixes gutter variable and other corrections

* Adds comment for gallery item width magic number
@dgutride
Copy link
Member

dgutride commented May 4, 2018

Work completed via #190 - closing

@dgutride dgutride closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andresgalante andresgalante

@kybaker kybaker

@srambach srambach

Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.1
Development

No branches or pull requests
6 participants
@cliffpyles @andresgalante @kybaker @dgutride @LHinson @srambach