Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description list demo #1921

Closed
mcarrano opened this issue Jun 12, 2019 · 5 comments · Fixed by #4715
Closed

Description list demo #1921

mcarrano opened this issue Jun 12, 2019 · 5 comments · Fixed by #4715
Assignees
Milestone

Comments

@mcarrano
Copy link
Member

mcarrano commented Jun 12, 2019

https://marvelapp.com/prototype/6e72b59

Create a demo to show how a definition list can be built in PatternFly (using the Description list component).


From the design looks like we can consider creating 4 things:

  • Basic demo - not sure how useful that is? Might serve as a good baseline for other demos.
  • Editable demo - this could also go in the inline edit component. We had an example for an editable <dl> that's commented out - probably makes sense to re-enable that with the new description list component. Then we could simply show the list term/item as editable with the edit icon as shown in the designs.
  • Description list in a drawer - unless this shows something unique, I don't think this is useful. Pretty much anything can go in a drawer.
  • Complex content demo - the demos with tables in the list item are probably good to show.
@rachael-phillips rachael-phillips added the Feature end user feature that requires design to define this, i.e. changes or augments the user experience. label Jun 13, 2019
@stale
Copy link

stale bot commented Jul 29, 2020

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jul 29, 2020
@mcoker
Copy link
Contributor

mcoker commented Aug 10, 2020

@mcarrano do you want to add this to the roadmap?

@mcarrano mcarrano added the demo label Aug 13, 2020
@mcarrano mcarrano added this to Unplanned in PatternFly Feature Roadmap Aug 13, 2020
@mcarrano mcarrano moved this from Unplanned to 2021.01 - TBD in PatternFly Feature Roadmap Sep 4, 2020
@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Oct 22, 2020
@mcarrano
Copy link
Member Author

Keep open

@stale stale bot removed the wontfix This will not be worked on label Oct 22, 2020
@mcarrano mcarrano moved this from 2021.01 - Jan 28 2021 to 2021.04 - March 31 2021 in PatternFly Feature Roadmap Nov 23, 2020
@mcarrano mcarrano moved this from 2021.04 - March 31 2021 to Unplanned in PatternFly Feature Roadmap Nov 23, 2020
@mcarrano mcarrano moved this from Unplanned / On hold to 2022.04 - April 1 2022 in PatternFly Feature Roadmap Oct 29, 2021
@mcarrano mcarrano added this to the 2022.03 milestone Oct 29, 2021
@mcarrano mcarrano removed this from 2022.04 - April 1 2022 in PatternFly Feature Roadmap Jan 6, 2022
@mcoker mcoker changed the title Definition list demo Description list demo Feb 16, 2022
@patternfly-build
Copy link

🎉 This issue has been resolved in version 4.181.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants