New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(description-list): added description list demo #4715
feat(description-list): added description list demo #4715
Conversation
Preview: https://patternfly-pr-4715.surge.sh A11y report: https://patternfly-pr-4715-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good @mattnolting . I agree regarding the edit in-place example. I do have a couple of question for @mceledonia , however.
1- When a description list is placed in a page as in these demos, should it be on a white or gray background? The designs show white, however to get that, would we place this inside a card?
2- The drawer example feels a bit dense to me vs the designs, but I can't say why. Anything different that you would recommend @mceledonia ?
Here is the design link: https://marvelapp.com/prototype/6e72b59/screen/85219622
c2bd496
to
5618aa7
Compare
@mcarrano I can place the description list in a page main section with a white background or a card, but because of the age of the mockups, I assumed the page main section should be white. Happy to update however you want.
I updated the width of the drawer panel to have a bit more room. |
We will want to be sure they work on both, but I do think inside of a card or on a white background is where this will be used most.
This new spacing in the drawer panel looks good to me! |
fb7ec20
to
ac13afe
Compare
@mcarrano @mceledonia I've updated the demos to show several content color combinations. https://patternfly-pr-4715.surge.sh/components/description-list/html-demos/basic |
95ae811
to
8655650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LPTM!! Do you need to set the table bg color? Doesn't seem like it's necessary since it's against a white background.
{{/description-list-text}} | ||
{{/description-list-term}} | ||
{{#> description-list-description}} | ||
{{#> table table--id="service-port" table--grid="true" table--modifier="pf-m-grid-md pf-m-compact" table--attribute='aria-label="Service address" style="--pf-c-table--BackgroundColor: transparent"'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{#> table table--id="service-port" table--grid="true" table--modifier="pf-m-grid-md pf-m-compact" table--attribute='aria-label="Service address" style="--pf-c-table--BackgroundColor: transparent"'}} | |
{{#> table table--id="service-port" table--grid="true" table--modifier="pf-m-grid-md pf-m-compact" table--attribute='aria-label="Service address"'}} |
{{/description-list-text}} | ||
{{/description-list-term}} | ||
{{#> description-list-description}} | ||
{{#> table table--id="service-address" table--grid="true" table--modifier="pf-m-grid-md pf-m-compact" table--attribute='aria-label="Service address" style="--pf-c-table--BackgroundColor: transparent"'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{#> table table--id="service-address" table--grid="true" table--modifier="pf-m-grid-md pf-m-compact" table--attribute='aria-label="Service address" style="--pf-c-table--BackgroundColor: transparent"'}} | |
{{#> table table--id="service-address" table--grid="true" table--modifier="pf-m-grid-md pf-m-compact" table--attribute='aria-label="Service address"'}} |
8655650
to
7af6ca9
Compare
🎉 This PR is included in version 4.181.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #1921
@mcarrano Inline edit isn't yet available via React outside of
pf-c-table
, so I think it's best to add those demo features when it's available globally.