Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workspace classes from code samples in Popover/Tooltip #526

Closed
jgiardino opened this issue Aug 3, 2018 · 2 comments
Closed

Remove workspace classes from code samples in Popover/Tooltip #526

jgiardino opened this issue Aug 3, 2018 · 2 comments
Assignees
@mcoker
Milestone
1.0.0-alpha.6

Comments

@jgiardino
Copy link
Contributor

Any workspace classes we use to adjust an example preview should not be included in the code sample.

The classes added to the Popover/Tooltip examples should be moved to examples/index.js. Refer to #442 (comment) for more details.
@jgiardino jgiardino mentioned this issue Aug 3, 2018
Merged
@LHinson LHinson added this to the 1.0.0-alpha.5 milestone Aug 3, 2018
@LHinson LHinson removed the alpha 4 label Aug 13, 2018
@dgutride
Copy link
Member

dgutride commented Sep 5, 2018

Took a look at the code and it will require some refactoring in the tooltip and popover to accomplish this since they can't stand along without the Preview__overlay and &-container classes being applied to the outside divs.

@matthewcarleton matthewcarleton mentioned this issue Sep 11, 2018
Closed
@LHinson LHinson modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.6 Sep 12, 2018
@LHinson LHinson assigned mcoker and unassigned andresgalante and dgutride Sep 17, 2018
@LHinson LHinson added this to CSS/HTML Development in PatternFly 4 Feature Board Sep 18, 2018
@mcoker
Copy link
Contributor

mcoker commented Oct 8, 2018

This was addressed via #688 with PR #747

@mcoker mcoker closed this as completed Oct 8, 2018
@LHinson LHinson moved this from CSS/HTML Development to Checkpoint 2 in PatternFly 4 Feature Board Oct 9, 2018
@mcarrano mcarrano removed this from Checkpoint 2 (Final Design Review) in PatternFly 4 Feature Board Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcoker mcoker

Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.6
Development

No branches or pull requests
5 participants
@andresgalante @dgutride @LHinson @jgiardino @mcoker