Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further testing of tooltip/popover #688

Closed
matthewcarleton opened this issue Sep 4, 2018 · 1 comment
Closed

Further testing of tooltip/popover #688

matthewcarleton opened this issue Sep 4, 2018 · 1 comment
Assignees
Milestone

Comments

@matthewcarleton
Copy link
Contributor

matthewcarleton commented Sep 4, 2018

We need to test further what the tooltip and popover look like when in use. As far as I know we have yet to test this in any real world scenarios. There could be a separate issue to update depending on the findings of this test.

Also address issue #526 in this issue.
Additionally, the popover icon is impacted by #510 and needs updated.

@LHinson LHinson added this to the 1.0.0-alpha.6 milestone Sep 5, 2018
@andresgalante andresgalante self-assigned this Sep 5, 2018
@LHinson LHinson added this to CSS/HTML Development in PatternFly 4 Feature Board Sep 10, 2018
@mcoker mcoker self-assigned this Sep 13, 2018
@jgiardino
Copy link
Contributor

jgiardino commented Sep 20, 2018

Can we add aria-haspopup="dialog" to the toggle that displays a popover, as part of this?
Oh, nevermind. The wai-aria example of a modal doesn't even use this attribute. And I found this article that recommends not using it until support is better.

Also, it's possible that any updates for this issue would result in closing a related issue to update the documentation sections: #527

@LHinson LHinson moved this from CSS/HTML Development to Checkpoint 2 in PatternFly 4 Feature Board Oct 1, 2018
@mcarrano mcarrano removed this from Checkpoint 2 (Final Design Review) in PatternFly 4 Feature Board Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants