Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor click/select/expand affordances for data lists and tables #5347

Closed
mcarrano opened this issue Jan 20, 2023 · 3 comments · Fixed by #5397
Closed

Refactor click/select/expand affordances for data lists and tables #5347

mcarrano opened this issue Jan 20, 2023 · 3 comments · Fixed by #5397
Assignees
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience. PF5 released on @alpha
Milestone

Comments

@mcarrano
Copy link
Member

Follow up to patternfly/patternfly-design#1211

Updates to the table rows behavior/interactions:

  1. Selectable table rows: (same behavior/interaction as current)
    There is a hover on the checkbox via mouse and keyboard. Selection is done by clicking the checkbox and the visual affordance is the checkbox appears to show the row is selected. There is no hover on the row itself.

  2. Expanding table rows:
    There is a hover on the caret via mouse and keyboard. Expansion is done by clicking the caret. There is no hover on the row itself. Updates: Once the row expands, the visual affordance will no longer be the left blue border to indicate expansion, instead it will be the removal of the bottom border of the parent row and the growing of the row into the expanded row content. The expanded row content will also be indented to be in line with the first column content.
    Expandable-3

  3. Clickable table rows [primary-detail view only]:
    There is a hover on the row via mouse and keyboard (drop shadow and blue border). The row can be clicked to produce the action of opening the primary-detail drawer. Updates: Once the primary-detail drawer opens, the visual affordance will be updated to be a thicker left blue border (double the width of current) so it can be clearly seen in both cases where the table has content padding and where it doesn't.
    Primary-detail no padding
    Clickable-3

Note that while these mocks are specifically for tables, the same changes should be applied to clickable/expandable data lists.

@mcarrano mcarrano added Feature end user feature that requires design to define this, i.e. changes or augments the user experience. needs triage Needs to be reviewed and prioritized PF5 and removed needs triage Needs to be reviewed and prioritized labels Jan 20, 2023
@mcarrano mcarrano added this to the 2023.03 milestone Jan 20, 2023
@nicolethoen
Copy link
Contributor

clickable should be the word used in var names and class names rather than hoverable and selectable

@thatblindgeye
Copy link
Contributor

Per convo with @mcarrano on Slack:

  • For Table > compound expansion, the expanded content should also have the left border removed when expanded (but keep all other borders currently present)
  • For Data List > nested expandable, the horizontal border should remain between the expandable row and a nested expandable row, but should be removed otherwise
    • Additional ask for the horizontal borders for nested expandable data list rows is having the border indented/align closer to the nested toggle

@patternfly-build
Copy link

🎉 This issue has been resolved in version 5.0.0-alpha.38 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature end user feature that requires design to define this, i.e. changes or augments the user experience. PF5 released on @alpha
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants