Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Toolbar - examples with selects misaligned on firefox #5532

Closed
Tracked by #53
nicolethoen opened this issue Apr 27, 2023 · 2 comments · Fixed by #5565
Closed
Tracked by #53

Bug - Toolbar - examples with selects misaligned on firefox #5532

nicolethoen opened this issue Apr 27, 2023 · 2 comments · Fixed by #5565
Assignees
@mattnolting
Labels
bug Something isn't working PF5 released on @alpha
Milestone
2023.06

Comments

@nicolethoen
Copy link
Contributor

Seems to be an issue with how MenuToggles are rendering

Screenshot 2023-04-27 at 7 59 39 AM
Screenshot 2023-04-27 at 7 59 43 AM
@nicolethoen nicolethoen added bug Something isn't working PF5 labels Apr 27, 2023
@nicolethoen nicolethoen added this to the 2023.07 milestone Apr 27, 2023
This was referenced Apr 27, 2023
Closed
Merged
Closed
@nicolethoen nicolethoen modified the milestones: 2023.07, 2023.06 May 2, 2023
@nicolethoen nicolethoen transferred this issue from patternfly/patternfly-react May 4, 2023
@nicolethoen nicolethoen assigned mcoker and unassigned mcoker May 4, 2023
@mcoker
Copy link
Contributor

mcoker commented May 4, 2023 •
edited

Looks like this is due to the baseline alignment introduced in #5201, and isn't limited to just selects/toggles. Here is a dropdown next to a text input group that are misaligned:

Screenshot 2023-05-04 at 10 08 31 AM

@mattnolting mattnolting mentioned this issue May 16, 2023
Merged
@nicolethoen nicolethoen mentioned this issue May 18, 2023
Closed
11 tasks
@patternfly-build
Copy link

🎉 This issue has been resolved in version 5.0.0-alpha.66 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this issue Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattnolting mattnolting

Labels
bug Something isn't working PF5 released on @alpha
Projects
PatternFly Issues
Archived in project
Milestone
2023.06
Development

Successfully merging a pull request may close this issue.

fix(toolbar): fixed vertical alignment issue mattnolting/patternfly
4 participants
@mattnolting @patternfly-build @nicolethoen @mcoker