-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds content to toolbar examples #8906
Conversation
Preview: https://patternfly-react-pr-8906.surge.sh A11y report: https://patternfly-react-pr-8906-a11y.surge.sh |
@edonehoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels odd to me that Sticky Toolbar is the first example. It was not previously. Is there are reason we changed the order?
Also, @nicolethoen , I assume it's unrelated to this PR, but do we understand why we are see a vertical mis-alignment now of certain items in toolbar examples?
### Adjusting item spacers | ||
### Toolbar item spacers | ||
|
||
You may adjust the space between toolbar items to arrange them into groups. [Read our spacers documentation](/v4/guidelines/spacers) to learn more about using spacers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This url leads to a 404 page. @mcarrano does/will this page exist in the updated page structure of PatternFly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the link for now to avoid the 404, but we can add it back when we figure out where to accurately point it
which examples? I am not seeing misalignment when I preview the toolbar examples @mcarrano |
@nicolethoen I see the problem here, for example: https://patternfly-react-pr-8906.surge.sh/components/toolbar#component-managed-toggle-groups I only see this in Firefox. Not in Chrome. |
Ah I am not seeing that on chrome - but i see it on firefox. bummer. We can open a follow up issue for that |
@mcarrano here is the follow up issue to address select alignment in toolbars in firefox: patternfly/patternfly#5532 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolethoen Thanks for opening the follow-up. I approve then.
Regarding "It feels odd to me that Sticky Toolbar is the first example. It was not previously. Is there are reason we changed the order?": I thought that it seemed like the most "basic" example since it referred to the toolbar behavior itself, rather than the toolbar items. But, if it seems odd, that was my only reason. I went ahead and moved it back to its original location assuming that makes better sense overall! |
Looks great. Thanks for the update @edonehoo . |
Makes progress on patternfly/patternfly-org#2990