Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable font opt-in should be prefixed #5616

Closed
mcoker opened this issue May 24, 2023 · 0 comments · Fixed by #5617
Closed

Variable font opt-in should be prefixed #5616

mcoker opened this issue May 24, 2023 · 0 comments · Fixed by #5617
Assignees
@mcoker
Labels
bug Something isn't working
Milestone
2023.07

Comments

@mcoker
Copy link
Contributor

mcoker commented May 24, 2023

patternfly/src/patternfly/base/_variables.scss

Lines 283 to 288 in be98c51

// Variable font opt-in
.pf-m-vf-font {
--#{$pf-global}--FontFamily--text: var(--#{$pf-global}--FontFamily--text--vf);
--#{$pf-global}--FontFamily--heading: var(--#{$pf-global}--FontFamily--heading--vf);
--#{$pf-global}--FontFamily--monospace: var(--#{$pf-global}--FontFamily--monospace--vf);
}

This should probably live in https://github.com/patternfly/patternfly/blob/v5/src/patternfly/base/_common.scss, too.
@mcoker mcoker added the bug Something isn't working label May 24, 2023
@mcoker mcoker added this to the 2023.07 milestone May 24, 2023
@mcoker mcoker self-assigned this May 24, 2023
@mcoker mcoker mentioned this issue May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcoker mcoker

Labels
bug Something isn't working
Projects
PatternFly Issues
Archived in project
Milestone
2023.07
Development

Successfully merging a pull request may close this issue.

fix(global): moved/prefixed variable font opt-in mcoker/patternfly
1 participant
@mcoker