Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Page Layout dark theme CSS #907

Closed
mcoker opened this issue Nov 7, 2018 · 0 comments
Closed

Fix Page Layout dark theme CSS #907

mcoker opened this issue Nov 7, 2018 · 0 comments
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Nov 7, 2018

currently the page layout uses this to apply dark theme var changes

&[class^="pf-m-dark"] {
    @extend %pf-t-dark; // force the container to follow the dark theme
  }

however, as you can see on the PageLayout examples, the vars aren't changing (the text should be white on a dark theme). that's because the class list has to start with .pf-m-dark* and the examples don't. we should either update the attr selector to target pf-m-dark anywhere in the class or update the examples.

* edit - also, the left/bottom padding values are out of order.

.pf-l-page__main-section {
  padding:
    var(--pf-l-page__main-section--PaddingTop)
    var(--pf-l-page__main-section--PaddingRight)
    var(--pf-l-page__main-section--PaddingLeft)
    var(--pf-l-page__main-section--PaddingBottom);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants