New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form/login/wizard): fixed undefined issues with IE11 script #1871
Changes from all commits
d016645
f8ff830
6b7abc5
8590ce7
4cb5b0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,29 @@ | |
--pf-c-wizard__description--PaddingTop: var(--pf-global--spacer--sm); | ||
--pf-c-wizard__description--Color: var(--pf-global--Color--light-200); | ||
|
||
// Nav link | ||
--pf-c-wizard__nav-link--Color: var(--pf-global--Color--100); | ||
--pf-c-wizard__nav-link--TextDecoration: var(--pf-global--link--TextDecoration); | ||
--pf-c-wizard__nav-link--hover--Color: var(--pf-global--link--Color); | ||
--pf-c-wizard__nav-link--focus--Color: var(--pf-global--link--Color); | ||
--pf-c-wizard__nav-link--m-current--Color: var(--pf-global--link--Color); | ||
--pf-c-wizard__nav-link--m-disabled--Color: var(--pf-global--Color--dark-200); | ||
|
||
// Nav link number | ||
--pf-c-wizard__nav-link--before--Width: 1.5rem; | ||
--pf-c-wizard__nav-link--before--Height: 1.5rem; | ||
--pf-c-wizard__nav-link--before--Top: 0; | ||
--pf-c-wizard__nav-link--before--BackgroundColor: var(--pf-global--BackgroundColor--300); | ||
--pf-c-wizard__nav-link--before--BorderRadius: var(--pf-global--BorderRadius--lg); | ||
--pf-c-wizard__nav-link--before--Color: var(--pf-global--Color--100); | ||
--pf-c-wizard__nav-link--before--FontSize: var(--pf-global--FontSize--sm); | ||
--pf-c-wizard__nav-link--before--Transform: translateX(calc(-100% - var(--pf-global--spacer--sm))); | ||
--pf-c-wizard__nav-link--m-current--before--BackgroundColor: var(--pf-global--active-color--100); | ||
--pf-c-wizard__nav-link--m-current--before--Color: var(--pf-global--Color--light-100); | ||
--pf-c-wizard__nav-link--m-disabled--before--BackgroundColor: transparent; | ||
--pf-c-wizard__nav-link--m-disabled--before--Color: var(--pf-global--Color--dark-200); | ||
|
||
|
||
// Toggle | ||
--pf-c-wizard__toggle--BackgroundColor: var(--pf-global--BackgroundColor--100); | ||
--pf-c-wizard__toggle--ZIndex: var(--pf-global--ZIndex--sm); | ||
|
@@ -57,15 +80,15 @@ | |
// Toggle number | ||
--pf-c-wizard__toggle-num--before--Top: #{pf-size-prem(2px)}; | ||
|
||
// Toggle list | ||
--pf-c-wizard__toggle-list--MarginRight: var(--pf-global--spacer--sm); | ||
--pf-c-wizard__toggle-list--MarginBottom: calc(var(--pf-c-wizard__toggle-list-item--MarginBottom) * -1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you mean to remove this? Seems like you want to just move it below where There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did mean to remove it because this one also came out to be zero. I'll double check to make sure. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah my mistake thanks will add it back. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
|
||
// Toggle list item | ||
--pf-c-wizard__toggle-list-item--first-child--FontSize: var(--pf-global--FontSize--lg); | ||
--pf-c-wizard__toggle-list-item--not-last-child--MarginRight: var(--pf-global--spacer--sm); | ||
--pf-c-wizard__toggle-list-item--MarginBottom: var(--pf-global--spacer--xs); | ||
|
||
// Toggle list | ||
--pf-c-wizard__toggle-list--MarginRight: var(--pf-global--spacer--sm); | ||
--pf-c-wizard__toggle-list--MarginBottom: calc(var(--pf-c-wizard__toggle-list-item--MarginBottom) * -1); | ||
|
||
// Toggle separator | ||
--pf-c-wizard__toggle-separator--MarginLeft: var(--pf-global--spacer--sm); | ||
--pf-c-wizard__toggle-separator--Color: var(--pf-global--BorderColor--200); | ||
|
@@ -82,7 +105,6 @@ | |
--pf-c-wizard__nav--lg--Width: #{pf-size-prem(300px)}; | ||
--pf-c-wizard--m-compact-nav__nav--lg--Width: #{pf-size-prem(250px)}; | ||
|
||
|
||
@media screen and (min-width: $pf-global--breakpoint--lg) { | ||
--pf-c-wizard__nav--BoxShadow: var(--pf-c-wizard__nav--lg--BoxShadow); | ||
} | ||
|
@@ -102,32 +124,9 @@ | |
--pf-c-wizard__nav-list--PaddingLeft: var(--pf-c-wizard__nav-list--lg--PaddingLeft); | ||
} | ||
|
||
|
||
// Nav item | ||
--pf-c-wizard__nav-item--MarginTop: var(--pf-global--spacer--md); | ||
|
||
// Nav link | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh you moved this block instead of the It should be
|
||
--pf-c-wizard__nav-link--Color: var(--pf-global--Color--100); | ||
--pf-c-wizard__nav-link--TextDecoration: var(--pf-global--link--TextDecoration); | ||
--pf-c-wizard__nav-link--hover--Color: var(--pf-global--link--Color); | ||
--pf-c-wizard__nav-link--focus--Color: var(--pf-global--link--Color); | ||
--pf-c-wizard__nav-link--m-current--Color: var(--pf-global--link--Color); | ||
--pf-c-wizard__nav-link--m-disabled--Color: var(--pf-global--Color--dark-200); | ||
|
||
// Nav link number | ||
--pf-c-wizard__nav-link--before--Width: 1.5rem; | ||
--pf-c-wizard__nav-link--before--Height: 1.5rem; | ||
--pf-c-wizard__nav-link--before--Top: 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead of moving just these 3 lines, can you move this whole block up so that the |
||
--pf-c-wizard__nav-link--before--BackgroundColor: var(--pf-global--BackgroundColor--300); | ||
--pf-c-wizard__nav-link--before--BorderRadius: var(--pf-global--BorderRadius--lg); | ||
--pf-c-wizard__nav-link--before--Color: var(--pf-global--Color--100); | ||
--pf-c-wizard__nav-link--before--FontSize: var(--pf-global--FontSize--sm); | ||
--pf-c-wizard__nav-link--before--Transform: translateX(calc(-100% - var(--pf-global--spacer--sm))); | ||
--pf-c-wizard__nav-link--m-current--before--BackgroundColor: var(--pf-global--active-color--100); | ||
--pf-c-wizard__nav-link--m-current--before--Color: var(--pf-global--Color--light-100); | ||
--pf-c-wizard__nav-link--m-disabled--before--BackgroundColor: transparent; | ||
--pf-c-wizard__nav-link--m-disabled--before--Color: var(--pf-global--Color--dark-200); | ||
|
||
// Outer wrap | ||
--pf-c-wizard__outer-wrap--BackgroundColor: var(--pf-global--BackgroundColor--100); | ||
--pf-c-wizard__outer-wrap--lg--PaddingLeft: var(--pf-c-wizard__nav--lg--Width); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as @mcoker had on removing
--pf-c-wizard__toggle-list--MarginBottom
from wizard.scss - did you mean to remove it completely or just move this line below--pf-c-login__main-footer-links--MarginBottom
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, nevermind - I see this is actually self-referential?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. If you look now the margin there just computes to 0 since
--pf-c-login__main-footer-links--MarginBottom
isn't defined anywhere else.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this wasn't a mistake where it really should have been assigned to another variable. I'm not sure why it would have been put in there that way. But, I don't know what the original specs were.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I looked at the commit where this was introduced (#1281) and looks like a mistake. The layout matches the design in sketch, too.