New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(demo): add empty and loading state table demos #2254
Conversation
* also added primary action container to empty state to support designs
PatternFly-Next preview: https://patternfly-next-pr-2254.surge.sh |
Also updated .pf-c-empty-state__icon to be a container instead of just an icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcarrano updated the preview, would you mind checking again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now @mcoker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work 👍
{{/if}}> | ||
{{> @partial-block}} | ||
</div> | ||
{{else}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are a few axe issues
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>
@mattnolting thanks! build passes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 LGTM
🎉 This PR is included in version 2.31.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# 2019.08 release notes (2019-10-01) Packages released: - @patternfly/patternfly@2.x ## Components - **Charts:** - Adjust padding for pie and donut charts ([#2247](#2247)) - Set mix-blend-mode for better color contrast ([#2239](#2239)) - Update area chart opacity ([#2233](#2233)) - **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260)) - **Data list:** Make data list borders consistent with table ([#2289](#2289)) - **Data toolbar:** - Updated clear button mods ([#2248](#2248)) - Added in examples for expandable ([#2273](#2273)) - **Flex layout:** Wrapped flex items, update css ([#2214](#2214)) - **Wizard:** - Re-enabled wizard modal demos ([#2259](#2259)) - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296)) - **Navigation:** Added styling updates to dark nav ([#2283](#2283)) - **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264)) - **Pagination:** Added compact variation ([#2275](#2275)) - **Radio:** Updated the radio component example to single components ([#2231](#2231)) - **Table:** - Fixed a11y issues in org documentation/html/table ([#2282](#2282)) - Added empty and loading state table demos ([#2254](#2254)) - **Tooltip:** Added text align left modifier ([#2284](#2284)) - **Select:** - Added typeahead form wrapper, udpated css ([#2255](#2255)) - Add top expanded example ([#2026](#2026)) - **Chip group:** Add overflow to group ([#2278](#2278)) - **Button:** Add control modifier ([#2005](#2005)) ## Other - **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))
* Create 2019.08 release notes (2019-10-01) Adding new release notes * Update 2019.08 release notes (2019-10-01) # 2019.08 release notes (2019-10-01) Packages released: - @patternfly/patternfly@2.x ## Components - **Charts:** - Adjust padding for pie and donut charts ([#2247](#2247)) - Set mix-blend-mode for better color contrast ([#2239](#2239)) - Update area chart opacity ([#2233](#2233)) - **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260)) - **Data list:** Make data list borders consistent with table ([#2289](#2289)) - **Data toolbar:** - Updated clear button mods ([#2248](#2248)) - Added in examples for expandable ([#2273](#2273)) - **Flex layout:** Wrapped flex items, update css ([#2214](#2214)) - **Wizard:** - Re-enabled wizard modal demos ([#2259](#2259)) - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296)) - **Navigation:** Added styling updates to dark nav ([#2283](#2283)) - **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264)) - **Pagination:** Added compact variation ([#2275](#2275)) - **Radio:** Updated the radio component example to single components ([#2231](#2231)) - **Table:** - Fixed a11y issues in org documentation/html/table ([#2282](#2282)) - Added empty and loading state table demos ([#2254](#2254)) - **Tooltip:** Added text align left modifier ([#2284](#2284)) - **Select:** - Added typeahead form wrapper, udpated css ([#2255](#2255)) - Add top expanded example ([#2026](#2026)) - **Chip group:** Add overflow to group ([#2278](#2278)) - **Button:** Add control modifier ([#2005](#2005)) ## Other - **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263)) * Rename 2019.08 release notes (2019-10-01) to 2019.08 release notes (2019-10-01).MD Added .md file name * Update 2019.08 release notes (2019-10-01).MD Co-Authored-By: Michael Coker <35148959+mcoker@users.noreply.github.com> * alphabetize components
fixes #2171