feat(textarea): add horizontal and vertical resize variants #2331
Conversation
|
PatternFly-Next preview: https://patternfly-next-pr-2331.surge.sh |
|
|
||
| &.pf-m-resize-horizontal { | ||
| resize: horizontal; | ||
| } |
There was a problem hiding this comment.
Can you add max-width: 100% and a min-width to this?
There was a problem hiding this comment.
@mceledonia should we add a min-width to the textarea when you can resize it horizontally, to prevent sizing it down too narrow?
|
|
||
| &.pf-m-resize-vertical { | ||
| resize: vertical; | ||
| } |
There was a problem hiding this comment.
Maybe a min-height here?
There was a problem hiding this comment.
@mceledonia what about a min-height when you can resize it vertically to prevent sizing it down too short?
|
@mcarrano would you mind verifying the behavior from our discussion this morning? |
|
@mattnolting re: #2357 we discussed that this morning and decided not to impose a min/max-height/width beyond the changes in this PR. @mceledonia @mcarrano do you want to weigh in? |
|
@mcoker This looks great. @mattnolting we decided to keep this simple and not impose a max/min width or height. There does not seem to be any harm in letting the user control this other than constraining the resizing as implemented by this PR. |
|
🎉 This PR is included in version 2.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #2251