chore(fix): should not include "Main" property in package.json #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we are not using 'Main' property asn entry point it should be removed, it is not a required property In the case of the codesandbox it is causing the following error "Error: Could not fetch dependencies, please try again in a couple seconds: Something went wrong while packaging the dependency @patternfly/patternfly@2.43.1: ENOENT: no such file or directory, scandir '/tmp/960130286/node_modules/@patternfly/patternfly/n'"
|
PatternFly-Next preview: https://patternfly-next-pr-2549.surge.sh |
dgutride
reviewed
Dec 19, 2019
package name changed back to "@patternfly/patternfly"
dgutride
approved these changes
Dec 19, 2019
dlabrecq
approved these changes
Dec 20, 2019
|
🎉 This PR is included in version 2.46.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we are not using 'Main' property asn entry point it should be removed, it is not a required property
In the case of the codesandbox it is causing the following error
"Error: Could not fetch dependencies, please try again in a couple seconds: Something went wrong while packaging the
dependency @patternfly/patternfly@2.43.1: ENOENT: no such file or directory, scandir '/tmp/960130286/node_modules/@patternfly/patternfly/n'"