feat(size-report): add proper size report check #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some cleanup. a bit more organized this way I believe.
Only display changed values
fixed circleci config to call the correct size script
updated comment in bash script, make it a bit more clear what the script is doing.
added cli args to script for flex
redallen
commented
Jan 31, 2020
added some logic for new files cleaned up table styles a bit
added in logic to handle fonts layouts and top level css files
Added passing of args, we should be able to use this for other packages.
fix circleci exec call
small change to bash script so that we display usage if we pass in the command arg(will only except run or clean)
fixes to get artifacts loading in circleCI
fixes to get artifacts loading in circleCI (fishing...)
fixes to get artifacts loading in circleCI (again)
fixes to get artifacts loading in circleCI (maybe it's indentation)
fixes to get artifacts loading in circleCI (try loading artifacts differently...)
fixes to get artifacts loading in circleCI (try loading artifacts differently, one more time)
fixes to get artifacts loading in circleCI (try loading artifacts differently)
run test showing all files in report.
cleaned up html output a bit...
refactored a bit. We are now sorting...
Removed debug 'console.logs'
added back logic so we only display if there are changes...
Moved logic form bash script to JS script. fixed percentage logic. we now display colors associated with neg\pos values.
Fixed a couple issues todo with exec paths
Fixed for circleci config.
Fixed for circleci repo pathing
debug circleCI comment push
additional debug lines
additional debug lines(again...)
removed debug lines
removed all styling as it is not needed once posted to PR.
Add some console logging and try-catch to get more info from circleCI...
fixed location of artifacts...
A few minor fixes, along with code that now updates the comment so we do not have multiple tables through out the PR.
|
Doc preview: https://patternfly-next-pr-2638.surge.sh A11y report: https://patternfly-next-pr-2638-coverage.surge.sh Preview: https://patternfly-next-pr-2638.surge.sh CSS Size Report
|
redallen
changed the title
|
🎉 This PR is included in version 2.61.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2634
dist/*.cssgrows > 10%