fix(table-grid): move borders to ::after #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-3113.surge.sh A11y report: https://patternfly-pr-3113-coverage.surge.sh |
christiemolloy
requested changes
May 14, 2020
| @@ -43,14 +43,14 @@ | |||
| // Body | |||
| --pf-c-table-tbody--responsive--MarginTop: var(--pf-global--spacer--xs); | |||
| --pf-c-table-tbody--m-expanded--before--Top: var(--pf-global--spacer--sm); | |||
| --pf-c-table-tbody--responsive--BorderWidth: var(--pf-global--spacer--sm); | |||
| --pf-c-table--tbody--after--BorderWidth: var(--pf-global--BorderWidth--lg); | |||
| --pf-c-table-tbody--responsive--border-width--base: var(--pf-global--spacer--sm); | |||
There was a problem hiding this comment.
This var is --pf-c-table-tbody.... but the ones below are --pf-c-table--tbody...
|
|
||
| & tbody { | ||
| --pf-c-table--tbody--after--BorderLeftWidth: 0; | ||
| } | ||
| } | ||
|
|
||
| > tr > :first-child:not(.pf-c-table__check)::before { | ||
| > tr > :first-child:not(.pf-c-table__check)::after { | ||
| --pf-c-table__expandable-row--before--BorderLeftWidth: 0; |
There was a problem hiding this comment.
i think this should be --pf-c-table__expandable-row--after--BorderLeftWidth because this var was removed
|
This arrow should be pointing upwards
|
|
on FF im seeing a weird black box when I click on any of the buttons inside the table, I couldnt capture it in a screenshot because it disappears quick. can you see it. doesn't look like its coming from hover/focus/active
|
christiemolloy
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
::beforeborders to::afterborders to prevent the following hidden label ([data-label]::before)Breaking changes
This PR updates
.pf-c-tableborders to use::afterpseudos to draw borders, rather than::beforepseudos.The following variables have been removed. Any reference to them should be removed as they are no longer used in patternfly:
--pf-c-table__expandable-row--before--BorderRightWidthThe following variables have been renamed. Any reference to the old variable should be updated to use the new variable:
--pf-c-table-tbody--responsive—BorderWidthhas changed to--pf-c-table--tbody--responsive--border-width--base--pf-c-table--tbody--after—BorderWidthhas changed to--pf-c-table--tbody--after--border-width—base--pf-c-table-tr--responsive—BorderWidthhas changed to--pf-c-table-tr--responsive--border-width—base--pf-c-table-tr--responsive--last-child—BorderWidthhas changed to--pf-c-table-tr--responsive--last-child—BorderBottomWidth--pf-c-table-tbody--responsive—BorderWidthhas changed to--pf-c-table-tbody--responsive--border-width--base--pf-c-table-tr--responsive—BorderWidthhas changed to--pf-c-table-tr--responsive--border-width--base--pf-c-table--BorderWidthhas changed to--pf-c-table--border-width--base--pf-c-table__expandable-row--before--Tophas changed to--pf-c-table__expandable-row--after--Top--pf-c-table__expandable-row--before--Bottomhas changed to--pf-c-table__expandable-row--after--Bottom--pf-c-table__expandable-row--before--BorderWidthhas changed to--pf-c-table__expandable-row--after--border-width--base--pf-c-table__expandable-row--before--BorderLeftWidthhas changed to--pf-c-table__expandable-row--after--BorderLeftWidth--pf-c-table__expandable-row--before--BorderColorhas changed to--pf-c-table__expandable-row--after--BorderColor--pf-c-table__compound-expansion-toggle__button--before--BorderWidthhas changed to--pf-c-table__compound-expansion-toggle__button--before--border-width--base--pf-c-table__compound-expansion-toggle__button--after--BorderWidthhas changed to--pf-c-table__compound-expansion-toggle__button--after--border-width--base--pf-c-table-cell-th--responsive--PaddingTophas changed to--pf-c-table--cell--first-child--responsive--PaddingTop