Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Adjust chart tooltip padding #3347

Merged
merged 1 commit into from Jul 30, 2020
Merged

fix(charts): Adjust chart tooltip padding #3347

merged 1 commit into from Jul 30, 2020

Conversation

dlabrecq
Copy link
Member

Victory changed the way padding is applied to chart tooltips. With the latest Victory packages, the tooltip appears too large.

Fixes #3346

Before
Screen Shot 2020-07-29 at 8 26 50 PM

After
Screen Shot 2020-07-29 at 8 27 21 PM

@dlabrecq dlabrecq requested a review from mcoker July 30, 2020 01:18
@patternfly-build
Copy link

patternfly-build commented Jul 30, 2020

Preview: https://patternfly-pr-3347.surge.sh

A11y report: https://patternfly-pr-3347-coverage.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
components/TabContent/tab-content.css202 B0 B100.00
components/Drawer/drawer.css21.4 kB19.6 kB8.43
components/Tabs/tabs.css24.7 kB24.2 kB2.09
docs/components/Tabs/examples/Tabs.css302 BNaN kBNaN
patternfly-no-reset.css748.2 kB745.7 kB0.34
patternfly.css750.1 kB747.6 kB0.34
patternfly.min.css661.0 kB658.8 kB0.33
patternfly-charts.css9.8 kB9.8 kB-0.01
site/docs/components/Tabs/examples/Tabs.css302 BNaN kBNaN

@mcoker mcoker merged commit 5b82bfb into patternfly:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants