feat(togglegroup): add toggle group component #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-3355.surge.sh A11y report: https://patternfly-pr-3355-coverage.surge.sh CSS Size Report
|
mattnolting
reviewed
Jul 31, 2020
| {{/toggle-group-text}} | ||
| {{/toggle-group-button}} | ||
| {{> divider divider--type="div" divider--modifier="pf-m-vertical"}} | ||
| {{#> toggle-group-button toggle-group-button--modifier="pf-m-selected"}} |
There was a problem hiding this comment.
Suggested change
| {{#> toggle-group-button toggle-group-button--modifier="pf-m-selected"}} | |
| {{#> toggle-group-button}} |
Looks like you have two set to selected
There was a problem hiding this comment.
this is to demonstrated two things can be clicked.
mcoker
reviewed
Jul 31, 2020
| @@ -0,0 +1,6 @@ | |||
| <div class="pf-c-toggle-group__icon{{#if toggle-group-icon--modifier}} {{toggle-group-icon--modifier}}{{/if}}" | |||
mcoker
reviewed
Jul 31, 2020
| @@ -0,0 +1,6 @@ | |||
| <div class="pf-c-toggle-group__text{{#if toggle-group-text--modifier}} {{toggle-group-text--modifier}}{{/if}}" | |||
mcoker
reviewed
Jul 31, 2020
| border-bottom-right-radius: var(--pf-c-toggle-group__button--last-child--BorderBottomRightRadius); | ||
| } | ||
|
|
||
| &:hover { |
There was a problem hiding this comment.
added the focus state and going to follow up with @mceledonia on monday
mcoker
reviewed
Jul 31, 2020
| font-size: var(--pf-c-toggle-group__button--FontSize); | ||
| color: var(--pf-c-toggle-group__button--Color); | ||
| background-color: var(--pf-c-toggle-group__button--BackgroundColor); | ||
| border: 0; |
There was a problem hiding this comment.
should this be an inline-flex item?
There was a problem hiding this comment.
Should we support icon positioning the same way we do with the button component? That would be another reason to use a button component here.
There was a problem hiding this comment.
^ will follow up on this
mattnolting
reviewed
Jul 31, 2020
| font-size: var(--pf-c-toggle-group__button--FontSize); | ||
| color: var(--pf-c-toggle-group__button--Color); | ||
| background-color: var(--pf-c-toggle-group__button--BackgroundColor); | ||
| border: 0; |
There was a problem hiding this comment.
Suggested change
| border: 0; | |
| border: none; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2625
new PR from new forked repo
old PR #3295