Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification-badge): removed unread state border #3389

Merged
merged 2 commits into from Aug 10, 2020
Merged

fix(notification-badge): removed unread state border #3389

merged 2 commits into from Aug 10, 2020

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Aug 10, 2020

fixes #3388

@patternfly-build
Copy link

patternfly-build commented Aug 10, 2020 •
edited

Preview: https://patternfly-pr-3389.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
patternfly.css774.6 kB776.1 kB-0.19
patternfly-no-reset.css772.7 kB774.2 kB-0.20
patternfly.min.css683.6 kB685.1 kB-0.21
components/Page/page.css26.2 kB26.8 kB-2.03
components/NotificationBadge/notification-badge.css4.6 kB5.6 kB-20.99

A11y report: https://patternfly-pr-3389-coverage.surge.sh

mceledonia
mceledonia approved these changes Aug 10, 2020
View reviewed changes
Copy link

@mceledonia mceledonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update. Looks good!

mattnolting
mattnolting approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jcaianirh
jcaianirh approved these changes Aug 10, 2020
View reviewed changes
Copy link

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mcoker

@mcoker mcoker merged commit debfe07 into patternfly:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnolting mattnolting mattnolting approved these changes

@mceledonia mceledonia mceledonia approved these changes

@jcaianirh jcaianirh jcaianirh approved these changes

@christiemolloy christiemolloy Awaiting requested review from christiemolloy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove border from notification badge
5 participants
@mcoker @patternfly-build @mattnolting @mceledonia @jcaianirh