Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contextselector): add actions footer #3494

Merged
merged 3 commits into from Sep 29, 2020
Merged

feat(contextselector): add actions footer #3494

merged 3 commits into from Sep 29, 2020

Conversation

christiemolloy
Copy link
Member

closes #3475

@patternfly-build
Copy link

patternfly-build commented Sep 21, 2020 •
edited

Preview: https://patternfly-pr-3494.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
components/ContextSelector/context-selector.css8.9 kB8.1 kB8.84
docs/components/ContextSelector/examples/context-selector.css125 B59 B52.80
patternfly-no-reset.css837.8 kB837.0 kB0.09
patternfly.css839.7 kB838.9 kB0.09
patternfly.min.css742.1 kB741.3 kB0.10

mcoker
mcoker approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

mcarrano
mcarrano approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @christiemolloy . @gdoyle1 can you also take a look?

@mcarrano mcarrano mentioned this pull request Sep 24, 2020
Closed
mattnolting
mattnolting approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/patternfly/components/ContextSelector/examples/context-selector.css Outdated

#ws-core-c-context-selector-with-footer {
min-height: 380px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

gdoyle1
gdoyle1 approved these changes Sep 29, 2020
View reviewed changes
Copy link

@gdoyle1 gdoyle1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christiemolloy looks awesome! Thank you

@mcoker mcoker merged commit 67306fc into patternfly:master Sep 29, 2020
@redallen
Copy link
Contributor

🎉 This PR is included in version 4.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnolting mattnolting mattnolting approved these changes

@mcarrano mcarrano mcarrano approved these changes

@gdoyle1 gdoyle1 gdoyle1 approved these changes

@mcoker mcoker mcoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add actions footer to the Context menu
7 participants
@christiemolloy @patternfly-build @redallen @mattnolting @mcarrano @gdoyle1 @mcoker