Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): reverted badge menu to dropdown menu #3929

Merged

Conversation

mattnolting
Copy link
Contributor

closes #3923

@patternfly-build
Copy link

patternfly-build commented Mar 16, 2021

Preview: https://patternfly-pr-3929.surge.sh

A11y report: https://patternfly-pr-3929-coverage.surge.sh

CSS Size Report
NameCurrentPreviousDiff %
There are no changes in CSS file sizes

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but looks like we also need to update the menu used in the menu component drilldown breadcrumbs examples. https://patternfly-pr-3929.surge.sh/components/menu#drilldown-with-breadcrumbs--level-3

@mattnolting mattnolting force-pushed the fix-dropdown-badge-toggle-issue-3923 branch from 2108457 to 8613cf9 Compare March 24, 2021 01:01
@mattnolting mattnolting changed the title fix(dropdown): reverted menu to dd menu fix(dropdown): reverted menu to dropdown menu Mar 24, 2021
@mattnolting mattnolting force-pushed the fix-dropdown-badge-toggle-issue-3923 branch from 8613cf9 to 3df632b Compare March 24, 2021 01:46
@mattnolting
Copy link
Contributor Author

@mcoker updated!

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🥔TM!

@mcoker mcoker changed the title fix(dropdown): reverted menu to dropdown menu fix(dropdown): reverted badge menu to dropdown menu Mar 24, 2021
@mcoker mcoker merged commit c3255d9 into patternfly:master Mar 24, 2021
@redallen
Copy link
Contributor

🎉 This PR is included in version 4.92.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mattnolting mattnolting deleted the fix-dropdown-badge-toggle-issue-3923 branch January 6, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update badge dropdown toggle (and breadcrumb and menu examples) to use dropdown menu
4 participants