feat(toolbar): added item width control #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-3994.surge.sh A11y report: https://patternfly-pr-3994-coverage.surge.sh CSS Size Report
|
mcarrano
reviewed
Apr 12, 2021
mcoker
requested changes
Apr 13, 2021
|
|
||
| | Class | Applied to | Outcome | | ||
| | -- | -- | -- | | ||
| | `--pf-c-toolbar__item--Width{-on-[breakpoint]}: {width}` | `.pf-c-toolbar__item` | Modifies the width value of a `toolbar item`. | |
There was a problem hiding this comment.
Suggested change
| | `--pf-c-toolbar__item--Width{-on-[breakpoint]}: {width}` | `.pf-c-toolbar__item` | Modifies the width value of a `toolbar item`. | | |
| | `--pf-c-toolbar__item--Width{-on-[breakpoint]}: {width}` | `.pf-c-toolbar__item` | Modifies the width value of a toolbar item. | |
| @@ -133,3 +148,4 @@ When using the `.pf-c-input-group` always ensure labels are used outside the inp | |||
| | `.pf-c-input-group` | `<div>` | Initiates the input group. **Required** | | |||
| | `.pf-c-input-group__text` | `<span>` | Initiates the input group text. This can be used to show text, radio, icons, or check boxes. | | |||
| | `.pf-m-plain` | `.pf-c-input-group__text` | Removes the border from the text element. | | |||
| | `--pf-c-input-group--Width{-on-[breakpoint]}: {width}` | `.pf-c-input-group` | Modifies the width value of an `input group`. | | |||
There was a problem hiding this comment.
Suggested change
| | `--pf-c-input-group--Width{-on-[breakpoint]}: {width}` | `.pf-c-input-group` | Modifies the width value of an `input group`. | | |
| | `--pf-c-input-group--Width{-on-[breakpoint]}: {width}` | `.pf-c-input-group` | Modifies the width value of an input group. | |
| @@ -116,6 +116,21 @@ cssPrefix: pf-c-input-group | |||
| {{/input-group}} | |||
| ``` | |||
|
|
|||
| ### Width control | |||
There was a problem hiding this comment.
I'm wondering if we need this for an input group, or if we could just enable it on a toolbar item? Was there a reason we need it on an input group, too?
There was a problem hiding this comment.
My reasoning was that the same issue would occur outside of a toolbar. But we can limit this PR to toolbar
mattnolting
force-pushed
the
feat-toolbar-issue-3894
branch
from
59fc44c
to
e3dcd88
Compare
mattnolting
changed the title
|
@mcoker updated |
mattnolting
force-pushed
the
feat-toolbar-issue-3894
branch
from
7693984
to
928de2c
Compare
mcoker
changed the title
|
🎉 This PR is included in version 4.99.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3894
closes #3449
Added width control to and
toolbar item.