fix(helper-text): updated static and dynamic to use same icons

[bitwiseor]

fixes #4205

updated static demo icons to match dynamic demo icons (specifically default and indeterminate)

[patternfly-build]

Preview: https://patternfly-pr-4246.surge.sh

A11y report: https://patternfly-pr-4246-coverage.surge.sh

CSS Size Report

Name	Current	Previous	Diff %
There are no changes in CSS file sizes

[mcoker]

@mcarrano can you confirm the actual change needed for this?

Looking at the react component, the icons are the same - is that what we should be matching?

[mcarrano]

@mcoker No. The React component has inconsistent icons. The original problem was that we can different sets of icons in each example. The goal was to use the same icons for error, success, etc. Looks like the design is saying to use the filled circle versions and not the open versions for everything. Does that help?

[bitwiseor]

Should they be matching the icons in the React static with custom icons demo, but with filled circle versions for default and indeterminate as well?

[mcoker]

@bitwiseor sorry for the confusion. I met with @mcarrano and we determined these should be the icons used for both static and dynamic

We'll also want to make sure everywhere the component is used is updated. That should be:

• Helper text examples page
• Helper text demos page
• Password Strength demo

[mcoker]

LGTM!! 🥳

[mcoker]

@doruskova can you confirm the icons here are what you were expecting to see? https://patternfly-pr-4246.surge.sh/components/helper-text

[patternfly-build]

🎉 This PR is included in version 4.125.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[doruskova]

@mcoker Yes! They're correct. Thank you!