chore(utilities): add breakpoint options to docs #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-4409.surge.sh |
mcoker
requested changes
Oct 1, 2021
| | Class | Applied to | Outcome | | ||
| | ---------------------------------------------------------------------- | ---------- | --------------------------------------------------- | | ||
| | `.pf-u-font-size-{xs, sm, md, lg, xl, 2xl, 3xl, 4xl}{-on-[breakpoint]}`| `*` | Sets font-size to xs, sm, md, lg, xl, 2xl, 3xl, 4xl | | ||
| | `.pf-u-font-weight-{light, normal, bold}{-on-[breakpoint]}` | `*` | Sets font-size to light, normal, bold | |
There was a problem hiding this comment.
nit - missing a conjunction
Suggested change
| | `.pf-u-font-weight-{light, normal, bold}{-on-[breakpoint]}` | `*` | Sets font-size to light, normal, bold | | |
| | `.pf-u-font-weight-{light, normal, bold}{-on-[breakpoint]}` | `*` | Sets font-size to light, normal, or bold | |
| | `.pf-u-text-truncate` | `*` | Truncates text field | | ||
| | Class | Applied to | Outcome | | ||
| | ---------------------------------------------------------------------- | ---------- | --------------------------------------------------- | | ||
| | `.pf-u-font-size-{xs, sm, md, lg, xl, 2xl, 3xl, 4xl}{-on-[breakpoint]}`| `*` | Sets font-size to xs, sm, md, lg, xl, 2xl, 3xl, 4xl | |
There was a problem hiding this comment.
nit - missing a conjunction
Suggested change
| | `.pf-u-font-size-{xs, sm, md, lg, xl, 2xl, 3xl, 4xl}{-on-[breakpoint]}`| `*` | Sets font-size to xs, sm, md, lg, xl, 2xl, 3xl, 4xl | | |
| | `.pf-u-font-size-{xs, sm, md, lg, xl, 2xl, 3xl, 4xl}{-on-[breakpoint]}`| `*` | Sets font-size to xs, sm, md, lg, xl, 2xl, 3xl, or 4xl | |
|
🎉 This PR is included in version 4.142.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3702
Adds documentation about breakpoints to the text and background color utilities and consolidates some repeated options.