fix(menu-toggle): added rounded corners to primary #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-4494.surge.sh |
mcoker
reviewed
Nov 5, 2021
| @@ -130,6 +131,8 @@ | |||
| --pf-c-menu-toggle--active--BackgroundColor: var(--pf-c-menu-toggle--m-primary--active--BackgroundColor); | |||
| --pf-c-menu-toggle--m-expanded--Color: var(--pf-c-menu-toggle--m-primary--m-expanded--Color); | |||
| --pf-c-menu-toggle--m-expanded--BackgroundColor: var(--pf-c-menu-toggle--m-primary--m-expanded--BackgroundColor); | |||
|
|
|||
| border-radius: var(--pf-c-menu-toggle--m-primary--BorderRadius); | |||
There was a problem hiding this comment.
wdyt about adding this to the base toggle and using a var for the primary variation? then we can add that for other variations if we add them.
There was a problem hiding this comment.
oh sorry what I meant was like:
.pf-c-menu-toggle {
--pf-c-menu-toggle--BorderRadius: 0;
--pf-c-menu-toggle--m-primary--BorderRadius: var(--pf-global--BorderRadius--sm);
border-radius: var(--pf-c-menu-toggle--BorderRadius);
&.pf-m-primary {
--pf-c-menu-toggle--BorderRadius: var(--pf-c-menu-toggle--m-primary--BorderRadius);
}
}
Then we can just update the --BorderRadius var any time we need to introduce a border-radius to a variation instead of defining the property per variation.
mattnolting
force-pushed
the
fix-menu-toggle-4493
branch
from
33ef7cb
to
f18266d
Compare
mattnolting
force-pushed
the
fix-menu-toggle-4493
branch
from
f18266d
to
96f5ec9
Compare
|
🎉 This PR is included in version 4.156.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4493