chore(masthead): added masthead template #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-4683.surge.sh A11y report: https://patternfly-pr-4683-a11y.surge.sh |
mcoker
approved these changes
Feb 10, 2022
| @@ -1,4 +1,4 @@ | |||
| {{#> context-selector context-selector--modifier="pf-m-full-height" context-selector--id=(concat masthead--id '-context-selector') context-selector--label-text="Selected project"}} | |||
| {{#> context-selector context-selector--modifier="pf-m-full-height" context-selector--id=(concat masthead--id '-context-selector') context-selector--label-text="Selected project" context-selector--IsExpanded=false}} | |||
There was a problem hiding this comment.
I think you were using reset as the word here to unset a context param?
Suggested change
| {{#> context-selector context-selector--modifier="pf-m-full-height" context-selector--id=(concat masthead--id '-context-selector') context-selector--label-text="Selected project" context-selector--IsExpanded=false}} | |
| {{#> context-selector context-selector--modifier="pf-m-full-height" context-selector--id=(concat masthead--id '-context-selector') context-selector--label-text="Selected project" context-selector--IsExpanded=reset}} |
src/patternfly//components/Form/examples/Form.md: {{#> reset form-field-group--IsExpanded=reset}}
src/patternfly//components/Form/examples/Form.md: {{#> form-field-group form-field-group--id=(concat form--id '-field-group7') form-field-group--IsExpandable=reset}}
src/patternfly//components/Form/examples/Form.md: {{#> form-field-group form-field-group--id=(concat form--id '-field-group8') form-field-group--IsExpandable=reset}}
src/patternfly//components/Nav/templates/nav--drilldown--nav-item-submenu.hbs: {{#> nav-list nav-item--IsDrilldown=reset nav-item--expanded=reset}}
src/patternfly//components/Nav/templates/nav--drilldown--nav-item-submenu.hbs: {{#> nav-list nav-item--expanded=reset nav-item--IsDrilldown=reset}}
src/patternfly//components/Nav/templates/nav--drilldown--nav-item-submenu.hbs: {{#> nav-item nav-item--IsDrilldown=reset nav-item--IsFlyout="true"}}
src/patternfly//demos/Page/page-template-masthead-drilldown.hbs: {{#> menu-content menu-content--attribute=reset}}
src/patternfly//demos/Masthead/templates/masthead-demo--drilldown.hbs: {{#> menu-content menu-content--attribute=reset}}
| {{> page-template-skip-to-content}} | ||
| {{#> masthead masthead--id=(concat page--id '-masthead')}} | ||
| {{> masthead-toggle}} | ||
| {{!-- |
There was a problem hiding this comment.
fwiw with the other page demo templates, I put them in the page component dir so we can keep the demo stuff separate from the example stuff and it makes it easier to find files. Though I don't feel strongly about it if you think there is a better way.
An aside, I'd like to organize all of that better once we can make hbs changes in subdirs and the file watcher reload the workspace properly.
mcoker
changed the title
|
🎉 This PR is included in version 4.178.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4579
closes #4686
Masthead template applied to Page and Masthead demos.