fix(card): force dk theme dk section card bg color #4913
Conversation
|
Screenshots:
|
|
Preview: https://patternfly-pr-4913.surge.sh A11y report: https://patternfly-pr-4913-a11y.surge.sh |
|
@srambach I see now, I didn't make the connection that the different background color was specifically for the non-selectable state when amongst selectable cards. This makes a lot more sense now! |
| @@ -10,4 +11,8 @@ | |||
| --pf-c-card--m-selectable-raised--focus--BoxShadow: var(--pf-global--BoxShadow--lg); | |||
| --pf-c-card--m-selectable-raised--active--BoxShadow: var(--pf-global--BoxShadow--lg); | |||
| } | |||
|
|
|||
| .pf-c-page__main-section[class*="pf-m-dark-"] .pf-c-card { | |||
There was a problem hiding this comment.
This has the potential of styling cards we don't intend on styling, like if they're used in some other component and not directly against the background color of the main section. That said, I hadn't made any sort of considerations for the .pf-m-dark- page section backgrounds with the dark theme work, so I wonder how often they're used and if this is likely to even be a problem.
|
New screenshots with different section variants. |
|
🎉 This PR is included in version 4.201.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Previous PR #4889 changed the box shadow of cards on dark background. However, design would like all cards on a dark section to have the same background.
@mceledonia In some cases, the pf-m-non-selectable-raised card is a different color. Is this the desired result? They are a different color in the normal (light) theme.