Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fonts): removed Overpass font support #5169

Merged
merged 1 commit into from Nov 10, 2022
Merged

fix(fonts): removed Overpass font support #5169

merged 1 commit into from Nov 10, 2022

Conversation

jenny-s51
Copy link
Contributor

Closes #4219

@jenny-s51 jenny-s51 changed the base branch from main to v5 October 13, 2022 15:45
@patternfly-build
Copy link

patternfly-build commented Oct 13, 2022 •
edited

Preview: https://patternfly-pr-5169.surge.sh

A11y report: https://patternfly-pr-5169-a11y.surge.sh

mcoker
mcoker approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice!! LGTM!

@mcoker
Copy link
Contributor

mcoker commented Oct 18, 2022

For reference for anyone reviewing, here is the original issue that added the overpass opt-in - #2955

mcoker
mcoker approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! So nice to see all of this removed. Great job 👍👍

@mcoker mcoker changed the title feat(fonts): removed Overpass font support fix(fonts): removed Overpass font support Nov 10, 2022
@mcoker mcoker merged commit b859fe8 into patternfly:v5 Nov 10, 2022
@mcoker mcoker mentioned this pull request Nov 10, 2022
Closed
@patternfly-build
Copy link

🎉 This PR is included in version 1.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@patternfly-build
Copy link

🎉 This PR is included in version 5.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 15, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
c55e33d
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 15, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
0de96aa
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 22, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
35eaa40
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 22, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
c60cfc4
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Mar 2, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
f92f0e1
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Mar 2, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
02c21b6
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Mar 2, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
7821f14
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Mar 2, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
645a6d6
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Mar 2, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
f9a9318
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Mar 2, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
ba5bc1f
@mcoker mcoker mentioned this pull request May 3, 2023
Closed
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request May 18, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
2fc051b
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023
@jenny-s51 @mattnolting
fix(fonts): dropped support for overpass (patternfly#5169)
1bfdf6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

@mattnolting mattnolting Awaiting requested review from mattnolting

Assignees
No one assigned
Labels
breaking change 💥 released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Overpass font support
3 participants
@jenny-s51 @patternfly-build @mcoker