Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): added default border to secondary, cleaned up modifiers #5171

Merged
merged 3 commits into from Oct 24, 2022
Merged

fix(tabs): added default border to secondary, cleaned up modifiers #5171

merged 3 commits into from Oct 24, 2022

Conversation

jenny-s51
Copy link
Contributor

Closes #5128

@patternfly-build
Copy link

patternfly-build commented Oct 13, 2022 •
edited

Preview: https://patternfly-pr-5171.surge.sh

A11y report: https://patternfly-pr-5171-a11y.surge.sh

mcoker
mcoker requested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @jenny-s51! Just one thing - the tabs demos should currently reflect the correct usage of secondary tabs borders, and the secondary tabs in the modal tab demo do not have a bottom border. With this update, we'll need to add tabs--HasNoBorderBottom here, and I think we could use tabs--IsSecondary in favor of pf-m-secondary, too -

patternfly/src/patternfly/demos/Tabs/examples/Tabs.md

Line 388 in f060ea9

{{#> tabs tabs--id=(concat modal-template--id '-tabs') tabs--modifier="pf-m-inset-none pf-m-secondary"}}

mcoker
mcoker approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

src/patternfly/demos/Tabs/examples/Tabs.md Outdated Show resolved Hide resolved
@mcoker
Copy link
Contributor

mcoker commented Oct 18, 2022

@mmenestr would you mind reviewing this and make sure the tabs examples and demos look ok? This is the breaking change to add borders to secondary tabs by default.

@mmenestr
Copy link

Looks good, just missing the border in the modal example as well!

@jenny-s51 @mcoker
Update src/patternfly/demos/Tabs/examples/Tabs.md
6300dc9 
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
mcoker
mcoker approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

mmenestr
mmenestr approved these changes Oct 24, 2022
View reviewed changes
Copy link

@mmenestr mmenestr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Thanks @jenny-s51

@mcoker mcoker changed the title chore(tabs): added default border to secondary, cleaned up modifiers fix(tabs): added default border to secondary, cleaned up modifiers Oct 24, 2022
@mcoker mcoker merged commit 55708e1 into patternfly:v5 Oct 24, 2022
@patternfly-build
Copy link

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jenny-s51 jenny-s51 linked an issue Oct 31, 2022 that may be closed by this pull request
Tabs - add border to secondary, clean up modifiers #5128
Closed
@mcoker mcoker mentioned this pull request Nov 10, 2022
Closed
@patternfly-build
Copy link

🎉 This PR is included in version 5.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 15, 2023
@jenny-s51 @mattnolting
fix(tabs): added default border to secondary, cleaned up modifiers (p…
98e78ca 
…atternfly#5171)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 15, 2023
@jenny-s51 @mattnolting
fix(tabs): added default border to secondary, cleaned up modifiers (p…
a34aeb5 
…atternfly#5171)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 22, 2023
@jenny-s51 @mattnolting
fix(tabs): added default border to secondary, cleaned up modifiers (p…
72838ce 
…atternfly#5171)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request May 18, 2023
@jenny-s51 @mattnolting
fix(tabs): added default border to secondary, cleaned up modifiers (p…
980145e 
…atternfly#5171)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023
@jenny-s51 @mattnolting
fix(tabs): added default border to secondary, cleaned up modifiers (p…
1c68e26 
…atternfly#5171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoker mcoker mcoker approved these changes

@mmenestr mmenestr mmenestr approved these changes

@srambach srambach Awaiting requested review from srambach

Assignees
No one assigned
Labels
breaking change 💥 released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs - add border to secondary, clean up modifiers
4 participants
@jenny-s51 @patternfly-build @mcoker @mmenestr