Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification-drawer): set body to fill available vertical space #5214

Merged
merged 1 commit into from Nov 10, 2022
Merged

fix(notification-drawer): set body to fill available vertical space #5214

merged 1 commit into from Nov 10, 2022

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Nov 3, 2022

fixes #5091

@patternfly-build
Copy link

patternfly-build commented Nov 3, 2022 •
edited

Preview: https://patternfly-pr-5214.surge.sh

A11y report: https://patternfly-pr-5214-a11y.surge.sh

@mcoker mcoker changed the base branch from main to v5 November 9, 2022 23:32
@mcoker mcoker changed the base branch from v5 to main November 9, 2022 23:32
@mcoker mcoker changed the base branch from main to v5 November 9, 2022 23:33
mattnolting
mattnolting approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM!

@mcoker mcoker merged commit f7b85d5 into patternfly:v5 Nov 10, 2022
@patternfly-build
Copy link

🎉 This PR is included in version 1.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nicolethoen nicolethoen mentioned this pull request Nov 10, 2022
Closed
@patternfly-build
Copy link

🎉 This PR is included in version 5.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 15, 2023
@mcoker @mattnolting
fix(notification-drawer): set body to fill available vertical space (p…
ac89c89 
…atternfly#5214)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 15, 2023
@mcoker @mattnolting
fix(notification-drawer): set body to fill available vertical space (p…
a223d10 
…atternfly#5214)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Feb 22, 2023
@mcoker @mattnolting
fix(notification-drawer): set body to fill available vertical space (p…
293b4c2 
…atternfly#5214)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request May 18, 2023
@mcoker @mattnolting
fix(notification-drawer): set body to fill available vertical space (p…
15aa308 
…atternfly#5214)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023
@mcoker @mattnolting
fix(notification-drawer): set body to fill available vertical space (p…
d1e1358 
…atternfly#5214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnolting mattnolting mattnolting approved these changes

@srambach srambach Awaiting requested review from srambach

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification drawer - menus are cut off unnecessarily
3 participants
@mcoker @patternfly-build @mattnolting