chore(chip-group): require main and remove legacy example #5356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-5356.surge.sh A11y report: https://patternfly-pr-5356-a11y.surge.sh |
This reverts commit ec0fc92.
mcoker
reviewed
Jan 31, 2023
| @@ -8,7 +8,7 @@ | |||
| --pf-c-chip-group--PaddingBottom: 0; | |||
| --pf-c-chip-group--PaddingLeft: 0; | |||
| --pf-c-chip-group--RowGap: var(--pf-global--spacer--sm); | |||
| --pf-c-chip-group--ColumnGap: var(--pf-global--spacer--sm); | |||
| --pf-c-chip-group--ColumnGap: 0; | |||
There was a problem hiding this comment.
it's fine to leave, but this isn't used, so we could remove it, too.
There was a problem hiding this comment.
I think for flexibility it's good to have (it is used on line 43 if that's what you meant)
|
🎉 This PR is included in version 5.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Feb 15, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Feb 15, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Feb 22, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Feb 22, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Feb 22, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Feb 22, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Mar 2, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Mar 2, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Mar 2, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Mar 2, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Mar 2, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Mar 2, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
May 18, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5335
.pf-c-chip-group__maincontainer is now required--pf-c-chip-group__close--MarginLeftvariable