fix(Wizard): cleaned up CSS #5389
Conversation
|
Preview: https://patternfly-pr-5389.surge.sh A11y report: https://patternfly-pr-5389-a11y.surge.sh |
| {{#> wizard-title-text}} | ||
| {{{wizard-title-text--value}}} | ||
| {{/wizard-title-text}} | ||
| {{/if}} |
There was a problem hiding this comment.
It looks like if there was a partial block and wizard-title-text--value we'd get both - do we want that?
There was a problem hiding this comment.
Good catch; I can't imagine we would. Just pushed an update to resolve that.
There was a problem hiding this comment.
LGTM! Though these demos also need to be updated (the first 5) - https://patternfly-pr-5389.surge.sh/components/wizard/html-demos
thatblindgeye
force-pushed
the
iss5143_wizardCSS
branch
from
f40fed6
to
53bae40
Compare
| {{#> wizard-title-text}} | ||
| {{{wizard-title-text--value}}} | ||
| {{/wizard-title-text}} | ||
| {{else if @partial-block}} |
There was a problem hiding this comment.
This could probably just be an else, right?
There was a problem hiding this comment.
Yep! I can open a followup issue for some other components that could use a similar update (Badge being one)
There was a problem hiding this comment.
@thatblindgeye I'm sorry - I've learned that it's actually better to use the {{else if @partial-block}} so that you can use the syntax {{> thing}} rather than having to use an open and close {{#> thing}}{{/thing}}
There was a problem hiding this comment.
LGTM other than @srambach's comment about making this an else if again
thatblindgeye
force-pushed
the
iss5143_wizardCSS
branch
from
9c54438
to
dd543ca
Compare
|
🎉 This PR is included in version 5.0.0-alpha.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #5143
Also updated a Wizard example to use the new markup of Empty State