feat(toolbar): added row-gap to items/content-section #5398
Conversation
|
Preview: https://patternfly-pr-5398.surge.sh A11y report: https://patternfly-pr-5398-a11y.surge.sh |
mattnolting
force-pushed
the
feat-toolbar-3348
branch
from
25abf8d
to
b851b0e
Compare
mattnolting
force-pushed
the
feat-toolbar-3348
branch
3 times, most recently
from
f55979a
to
4025fe1
Compare
There was a problem hiding this comment.
In addition to the comment below, there were a few examples on the preview surge - when I shrunk my window width down - where the gap between a pf-c-toolbar__content-section and pf-c-toolbar__expandable-content was reduced compared to the live site (Stacked on mobile (filters collapsed, expandable content expanded)
, Selected filters on mobile (filters collapsed, expandable content expanded), and Toggle group on mobile (filters collapsed, expandable content expanded) ).
Live site:
Surge:
mattnolting
force-pushed
the
feat-toolbar-3348
branch
from
4025fe1
to
1905c26
Compare
mattnolting
force-pushed
the
feat-toolbar-3348
branch
from
1905c26
to
e1a61c6
Compare
|
@thatblindgeye Build is now good |
|
🎉 This PR is included in version 5.0.0-alpha.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat(toolbar): added row-gap to items/content-section * feat(toolbar): modifier section spacing * feat(toolbar): added margin-top and padding-bottom to exp * update
* feat(toolbar): added row-gap to items/content-section * feat(toolbar): modifier section spacing * feat(toolbar): added margin-top and padding-bottom to exp * update
closes #3348
The original request was to add
row-gapto toolbar, WITH modifiers. I don't think we need modifiers as the original intent was to prevent visual breakages when items/groups wrap and have no spacing. Once 5243 and 5270 are finalized and merged, that model will need to be applied to toolbar.