fix(global): rename default status color to custom #5418
Conversation
|
Preview: https://patternfly-pr-5418.surge.sh A11y report: https://patternfly-pr-5418-a11y.surge.sh |
mcoker
requested review from
mattnolting,
thatblindgeye and
wise-king-sullyman
and removed request for
mattnolting
| --pf-c-alert--BorderTopColor: var(--pf-c-alert--m-custom--BorderTopColor); | ||
| --pf-c-alert__icon--Color: var(--pf-c-alert--m-custom__icon--Color); | ||
| --pf-c-alert__title--Color: var(--pf-c-alert--m-custom__title--Color); | ||
| --pf-c-alert--m-inline--BackgroundColor: var(--pf-c-alert--m-inline--m-custom--BackgroundColor); |
There was a problem hiding this comment.
Doesn't look like --pf-c-alert--m-inline--m-custom--BackgroundColor is defined anywhere
| @@ -11,7 +11,7 @@ | |||
| Danger notification: | |||
| {{else if notification-drawer-list-item--IsSuccess}} | |||
| Success notification: | |||
| {{else if notification-drawer-list-item--IsDefault}} | |||
| {{else if notification-drawer-list-item--IsCustom}} | |||
| Default notification: | |||
There was a problem hiding this comment.
Would we want this updated to "Custom notification:" to follow similar updates in the Alert component?
| @@ -4,7 +4,7 @@ | |||
| {{/if}}> | |||
| {{#if popover--IsAlert}} | |||
| {{#> screen-reader}} | |||
| {{#if popover--IsDefaultAlert}} | |||
| {{#if popover--IsCustomAlert}} | |||
| Default | |||
There was a problem hiding this comment.
Similar to above, would we want this text to be "Custom" instead?
|
@thatblindgeye great catches! The full-page example screenshots are updated prior to a release, usually with the versioned commit that adds the release notes. Though you can run the job and push to this PR if you'd like! The instructions are at https://github.com/patternfly/patternfly/#update-screenshots Note that it may update more screenshots than this one since that job isn't run with each change and there have been a lot of changes since the last run. |
There was a problem hiding this comment.
@mcoker gotcha! Makes sense to do them all at once then. Everything else looks good!
There was a problem hiding this comment.
Line 127 - Should add '.pf-m-custom' as an acceptable modifier (or just remove the list and simply say always to use it with a state modifier)
removed explicit state classes, unbolded that part to match alert and button, which say the same thing.
|
🎉 This PR is included in version 5.0.0-alpha.34 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* fix(global): rename default status color to custom * chore(text): update default/custom docs * chore(examples): update example text * chore(notification-drawer): updated list-item docs removed explicit state classes, unbolded that part to match alert and button, which say the same thing.
* fix(global): rename default status color to custom * chore(text): update default/custom docs * chore(examples): update example text * chore(notification-drawer): updated list-item docs removed explicit state classes, unbolded that part to match alert and button, which say the same thing.
fixes #5175
Also makes a status variation required for the alert component. Previously the alert with no variant would give you the "default", aka "custom" status styling. Now the alert without a variation is unstyled and you have to add
.pf-m-custom.