fix(Dropdown): updated styling to resolve unexpected spacing #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-5425.surge.sh A11y report: https://patternfly-pr-5425-a11y.surge.sh |
thatblindgeye
force-pushed
the
iss4894_dropdown_spacing
branch
from
0227a74
to
b185c7e
Compare
|
🎉 This PR is included in version 5.0.0-alpha.35 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
May 18, 2023
…fly#5425) * fix(Dropdown): updated styling to resolve unexpected spacing * fix(Dropdown): refactored to use gap
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
…fly#5425) * fix(Dropdown): updated styling to resolve unexpected spacing * fix(Dropdown): refactored to use gap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4894
Also updates styling in ContextSelector and OptionsMenu in case.
This approach shouldn't really require any markup changes. The alternative would be doing something more similar to Select/Menu Toggle and place some sort of wrapper inside the toggle button and either apply the styling in this PR to it (like MenuToggle), or remove the styling here and just wrap everything but the arrow icon in a wrapper so that
space-betweendoesn't cause spacing issues (similar to Select).