fix(page): default page to full viewport height #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-5517.surge.sh A11y report: https://patternfly-pr-5517-a11y.surge.sh |
mcoker
changed the title
|
🎉 This PR is included in version 5.0.0-alpha.44 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
May 18, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5448
Removes
.pf-m-full-heightfor a page in lieu of defaulting the page to be 100vh/dvh with a max-height so it doesn't overrun the space it's allocated if it's within another layout.This will need a follow-on issue on .org to limit the width of all the page examples (this is currently done just for a couple of the examples).