Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(about-modal, background-image): updated to not ship default background image #5530

Merged
merged 2 commits into from May 11, 2023

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented May 4, 2023

fixes #5529, fixes #4930

  • No longer shipping the PF logo as the default for about modal and background image in the CSS, with approval from @mceledonia
  • Updated docs for ^ to note the var needed to set the background images
  • Removed $pf-global--image-path as it's no longer necessary
  • Updated form control sprite paths to no longer use the global var path so the SCSS will compile - those paths will be removed in Form controls - remove use of background images #5469

@mcoker mcoker requested a review from mceledonia May 4, 2023 03:44
@patternfly-build
Copy link

patternfly-build commented May 4, 2023

Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mcoker
Copy link
Contributor Author

mcoker commented May 8, 2023

@thatblindgeye @srambach rebased with the v5 versioning work.

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@mcoker mcoker merged commit 1fdc9d9 into patternfly:v5 May 11, 2023
1 check passed
@patternfly-build
Copy link

🎉 This PR is included in version 5.0.0-alpha.52 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request May 18, 2023
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants