fix(wizard): adjust z-indexes so menus show with overflow #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-5533.surge.sh A11y report: https://patternfly-pr-5533-a11y.surge.sh |
srambach
force-pushed
the
4794-wizard-menus
branch
from
f7a32c4
to
952a5b6
Compare
mcoker
approved these changes
May 9, 2023
There was a problem hiding this comment.
LGTM. It's worth noting that this doesn't currently work with menus that have a positioned parent within the wizard main area, like dropdown or select (the parent component class selector is positioned). It does work with the menu component in a standard wizard, since the menu's position is relative to the outer wrap element.
|
🎉 This PR is included in version 5.0.0-alpha.49 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
May 10, 2023
…#5533) * fix(wizard): adjust z-indexes so menus show with overflow * Update src/patternfly/components/Wizard/wizard.scss --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
May 10, 2023
…#5533) * fix(wizard): adjust z-indexes so menus show with overflow * Update src/patternfly/components/Wizard/wizard.scss --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
May 18, 2023
…#5533) * fix(wizard): adjust z-indexes so menus show with overflow * Update src/patternfly/components/Wizard/wizard.scss --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
…#5533) * fix(wizard): adjust z-indexes so menus show with overflow * Update src/patternfly/components/Wizard/wizard.scss --------- Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4794
Adjusts z-indexes of wizard components as demonstrated in https://codesandbox.io/s/elated-jerry-1xl9m5?file=/fonts.css