Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fixed typeahead form control border styles #5698

Merged
merged 1 commit into from Jun 30, 2023

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Jun 29, 2023

fixes #5697

screenshots - I just added a select component to a demo with a toolbar in dev tools to validate.

before
Screenshot 2023-06-29 at 3 56 17 PM

after
Screenshot 2023-06-29 at 3 56 00 PM

@patternfly-build
Copy link

patternfly-build commented Jun 29, 2023

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM 👍

@mcoker mcoker merged commit 2ecc873 into patternfly:main Jun 30, 2023
1 check passed
@patternfly-build
Copy link

🎉 This PR is included in version 5.0.0-prerelease.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@patternfly-build
Copy link

🎉 This PR is included in version 6.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - v5 preview testing - Select toolbar alignment
4 participants