Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-control): change divs to spans #5703

Merged
merged 2 commits into from Jul 5, 2023

Conversation

srambach
Copy link
Member

@srambach srambach commented Jul 3, 2023

Fixes #5701
Changes all the divs in a form control to be spans to allow a form control to be inside phrasing content.

@patternfly-build
Copy link

patternfly-build commented Jul 3, 2023

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcoker mcoker merged commit 443f457 into patternfly:main Jul 5, 2023
1 check passed
@patternfly-build
Copy link

🎉 This PR is included in version 5.0.0-prerelease.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jul 18, 2023
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
@patternfly-build
Copy link

🎉 This PR is included in version 6.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
@srambach srambach deleted the 5701-form-control-span branch April 6, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Form control - form control element wrapper should be span/phrasing content
3 participants