Removed repetitive background transparency assignment from secondary and tertiary button classes #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pf-next ready! Built with commit 06f2a72 |
| @@ -118,6 +109,8 @@ | |||
|
|
|||
| position: relative; | |||
| display: inline-block; | |||
| min-width: var(--pf-c-button--MinWidth); | |||
| min-height: var(--pf-c-button--MinWidth); | |||
There was a problem hiding this comment.
This is unrelated to your work but can you update this to be --pf-c-button--minHeight. It was missed on a previous review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #494
The buttons have a transparent background assigned by the .pf-c-button class.
I removed the extra background transparency assignment from the secondary and tertiary styles (including hover, focus, active) and now they just inherit the background transparency from the .pf-c-button class.